On Fri, 15 Aug 2025 15:46:58 GMT, Saint Wesonga <d...@openjdk.org> wrote:

>> [ml64](https://learn.microsoft.com/en-us/cpp/assembler/masm/ml-and-ml64-command-line-reference?view=msvc-170)
>>  is set as the assembler for the Windows platform but is specific to the x64 
>> platform. The 
>> [armasm64](https://learn.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-command-line-reference?view=msvc-170)
>>  assembler should be used for Windows AArch64.
>> 
>> The -c and -Ta options are only valid for ml64 and -Ta can be removed from 
>> CompileFile.gmk (assembling for x64 works without it).
>
> Saint Wesonga has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Reduce nesting levels

make/autoconf/flags-other.m4 line 118:

> 116:     BASIC_ASFLAGS="-x assembler-with-cpp"
> 117:   elif test "x$TOOLCHAIN_TYPE" = xmicrosoft; then
> 118:     BASIC_ASFLAGS="-nologo -c"

Should we need to update the copyright year from 2024 to 2025

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26791#discussion_r2281479220

Reply via email to