On Fri, 22 Aug 2025 15:55:38 GMT, Albert Mingkun Yang <[email protected]> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update testing.md, remove makefile link, fix bad text
>
> test/jdk/java/rmi/transport/dgcDeadLock/DGCDeadLock.java line 59:
>
>> 57: public class DGCDeadLock implements Runnable {
>> 58: final static public int HOLD_TARGET_TIME = 25000;
>> 59: public static final double TEST_FAIL_TIME = (HOLD_TARGET_TIME +
>> 30000) * Math.max(TestLibrary.getTimeoutFactor(), 4);
>
> Why `max(...)`? If it's for backwards compatibility, shouldn't it be
> `(HOLD_TARGET_TIME + 30000) * 4 * TestLibrary.getTimeoutFactor()`?
It is a way to give a "4x" lowest value, while not multiplying a 10x factor
with four resulting in a 40x factor. I think (but I am not sure) that it would
sometime time out if I only used the given timeout factor and not "guarding"
with the max(x, 4).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26749#discussion_r2297876217
