On Fri, 5 Sep 2025 17:08:30 GMT, Magnus Ihse Bursie <[email protected]> wrote:
> We should wrap the call to `mt` in `ExecuteWithLog`. I tried to do this > earlier but ran into problems with the tricky command line. The solution was > to use `$$(COMMA)` (and `$$(HASH)`); I'm not sure why I did not see this > before. > > I also noted that there is an actual bug in the MT command line -- the > trailing `;#1` is not protected from the shell, so the command line will end > after `-outputresource:$$@`, and then a new command -- the comment `#1` which > does nothing, will be executed. This works out anyway since if you leave out > the resource identifier index the value of `CREATEPROCESS_MANIFEST_RESOURCE` > will be used by default, and that happens to be 1. > (See https://learn.microsoft.com/en-us/windows/win32/sbscs/mt-exe) Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/27124#pullrequestreview-3196507421
