On Tue, 21 Oct 2025 15:18:32 GMT, Matthias Baesken <[email protected]> wrote:
>> When using stripped and not full pdb files on WIndows, the test >> CheckForProperDetailStackTrace.java misses source information (but this is >> not surprise with those much smaller pdb files; so probably we should not >> rely on having the source info available). >> error output is : >> >> >> java.lang.RuntimeException: Expected source information missing from output >> at >> CheckForProperDetailStackTrace.main(CheckForProperDetailStackTrace.java:145) >> at >> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) >> at java.base/java.lang.reflect.Method.invoke(Method.java:565) >> at >> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335) >> at java.base/java.lang.Thread.run(Thread.java:1474) > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Windows: add hasExternalSymbolsStripped to WhiteBox, use it in our test make/hotspot/lib/CompileJvm.gmk line 163: > 161: ifeq ($(SHIP_DEBUG_SYMBOLS), public) > 162: JVM_CFLAGS += -DHAS_STRIPPED_DEBUGINFO > 163: endif But IIUC building the stripped pdb files doesn't necessarily mean you have deployed them in your image. Also isn't there a way to define file specific flags so this only gets set for whitebox.cpp? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27899#discussion_r2451097941
