On Tue, 21 Oct 2025 15:18:32 GMT, Matthias Baesken <[email protected]> wrote:

>> When using stripped and not full pdb files on WIndows, the test 
>> CheckForProperDetailStackTrace.java misses source information (but this is 
>> not surprise with those much smaller pdb files; so probably we should not 
>> rely on having the source info available).
>> error output is :
>> 
>> 
>> java.lang.RuntimeException: Expected source information missing from output
>> at 
>> CheckForProperDetailStackTrace.main(CheckForProperDetailStackTrace.java:145)
>> at 
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:565)
>> at 
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
>> at java.base/java.lang.Thread.run(Thread.java:1474)
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Windows: add hasExternalSymbolsStripped to WhiteBox, use it in our test

> But IIUC building the stripped pdb files doesn't necessarily mean you have 
> deployed them in your image.

True, but in the end you have the stripped pdbs in place so it is possible you 
test with those and the test fails (for a good reason).
It is better than ALWAYS switching off the source file name check on Windows .

> Also isn't there a way to define file specific flags so this only gets set 
> for whitebox.cpp?

Yes I could do this, if you prefer ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27899#issuecomment-3431898876

Reply via email to