On Thu, 23 Oct 2025 16:06:11 GMT, Ioi Lam <[email protected]> wrote: >>> Given that we know have support for CDS from all GCs is it time to replace >>> all `INCLUDE_CDS_JAVA_HEAP` with just `INCLUDE_CDS`? >> >> I think we could do that indeed. However, I would like that to be a >> follow-up cleanup, to avoid cluttering more files in this PR. > >> > Given that we know have support for CDS from all GCs is it time to replace >> > all `INCLUDE_CDS_JAVA_HEAP` with just `INCLUDE_CDS`? >> >> I think we could do that indeed. However, I would like that to be a >> follow-up cleanup, to avoid cluttering more files in this PR. > > We have > > > #if INCLUDE_CDS && INCLUDE_G1GC && defined(_LP64) > #define INCLUDE_CDS_JAVA_HEAP 1 > > > So we need to make sure it works for 32 bit as well.
@iklam does this look okay now? ------------- PR Comment: https://git.openjdk.org/jdk/pull/27732#issuecomment-3482604226
