On Mon, 15 Sep 2025 16:37:18 GMT, Alan Bateman <[email protected]> wrote:
>> Right now, the static-jdk image is a bit strange in that it's a modular >> run-time image but with all native code compiled into bin/java. In time we >> hope that jlink will be able to create a static image where everything is in >> the single executable, so no bin directory (or any directory) for launchers. >> I don't object to doing something to help testing the intermediate step, >> just not sure that main line is the right place for this. >> >> As regards the shim when I wonder if it should use CreateProcessW but maybe >> it doesn't matter for the test environments where they will run. > >> @AlanBateman @jianglizhou Now that Erik has approved the build >> functionality, I'd appreciate if anyone of you could approve as well, then I >> can finally integrate this. > > I think it's okay, and good for testing. I went through the relauncher > closely, just not 100% sure of the quoting in the Windows implementation so > I'm hoping Roger will have a few mins to scan that function. @AlanBateman I updated the PR with a fix for the issue Roger found about quoting the executable name. Can you please re-approve? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24380#issuecomment-3490429458
