On Wed, 12 Nov 2025 01:36:19 GMT, Shawn M Emery <[email protected]> wrote:
>> Nick Hall has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address second set of @erikj79's build comments > > make/test/JtregNativeJdk.gmk line 126: > >> 124: # macOS: build with system krb5 and disable deprecation warnings >> 125: BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libNativeCredentialCacheHelper := >> -lkrb5 -lcom_err >> 126: BUILD_JDK_JTREG_LIBRARIES_CFLAGS_libNativeCredentialCacheHelper := >> -Wno-deprecated-declarations > > Why doesn't the macosx target use the KRB5* variables as well? Only because I was trying to avoid making changes there, but you're right - the resultant value of this on MacOS would be the hard-coded set of libs there, so there's no harm in using at (and potentially some advantage to people building on MacOS against a non-system version of Kerberos). Fixed in next commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28075#discussion_r2517970400
