> Please review a change to fix broken links in sealed type hierarchy graphs 
> for nested types. The problem is that SVG files for nested types use the 
> names of enclosing types as parent directories. Therefore, links from nested 
> type SVGs  must have a matching `../` for each enclosing type. 
> 
> Fixed graphs for some nested sealed types: 
>  - 
> [ClassFile.Option](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/ClassFile.Option.html)
>  - 
> [Signature.RefTypeSig](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/Signature.RefTypeSig.html)
>  - 
> [TypeAnnotation.TargetInfo](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/TypeAnnotation.TargetInfo.html)
> 
> There is currently no test coverage for the sealed graph taglet. I tested the 
> fix manually, a test should be added with 
> [JDK-8366828](https://bugs.openjdk.org/browse/JDK-8366828).

Hannes Wallnöfer has updated the pull request incrementally with one additional 
commit since the last revision:

  Add comment to explain SVG naming scheme

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28134/files
  - new: https://git.openjdk.org/jdk/pull/28134/files/eb3c1ec3..ef36422e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28134&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28134&range=01-02

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/28134.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28134/head:pull/28134

PR: https://git.openjdk.org/jdk/pull/28134

Reply via email to