On Tue, 4 Nov 2025 16:17:54 GMT, Hannes Wallnöfer <[email protected]> wrote:

>> Please review a change to fix broken links in sealed type hierarchy graphs 
>> for nested types. The problem is that SVG files for nested types use the 
>> names of enclosing types as parent directories. Therefore, links from nested 
>> type SVGs  must have a matching `../` for each enclosing type. 
>> 
>> Fixed graphs for some nested sealed types: 
>>  - 
>> [ClassFile.Option](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/ClassFile.Option.html)
>>  - 
>> [Signature.RefTypeSig](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/Signature.RefTypeSig.html)
>>  - 
>> [TypeAnnotation.TargetInfo](https://cr.openjdk.org/~hannesw/8366094/api.00/java.base/java/lang/classfile/TypeAnnotation.TargetInfo.html)
>> 
>> There is currently no test coverage for the sealed graph taglet. I tested 
>> the fix manually, a test should be added with 
>> [JDK-8366828](https://bugs.openjdk.org/browse/JDK-8366828).
>
> Hannes Wallnöfer has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update copyright year

I added a comment and updated the description to better explain the problem and 
fix.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28134#issuecomment-3531955266

Reply via email to