On Thu, 27 Nov 2025 00:31:23 GMT, Iris Clark <[email protected]> wrote:
>> Nizar Benalla has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Update --release 26 symbol information for JDK 26 build 25 >> The macOS/AArch64 build 25 was taken from https://jdk.java.net/26/ >> - revert MAX_COLUMNS to 80 >> - Update LATEST_MAJOR_VERSION in Versions.java >> - Merge branch 'master' into start-of-release-27 >> - Merge branch 'master' into start-of-release-27 >> - Merge branch 'master' into start-of-release-27 >> - Updates due to the generate-symbol-data.sh location changing in 8367259 >> - Updates due to the generate-symbol-data.sh location changing in 8367259 >> - Merge branch 'master' into start-of-release-27 >> - update links to JVMS 26 and 27 >> - ... and 2 more: https://git.openjdk.org/jdk/compare/a52f9076...78895b2b > > test/langtools/tools/javac/options/HelpOutputColumnWidthTest.java line 50: > >> 48: public class HelpOutputColumnWidthTest extends TestRunner { >> 49: >> 50: public static final int MAX_COLUMNS = 80; > > I though that the default terminal width was 24x80 in most systems, so 84 > seems an odd choice. I agree that 80 seems more appropriate. oops.. that should have been `80x24`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28130#discussion_r2566789434
