On Fri, 21 Nov 2025 15:39:12 GMT, Severin Gehwolf <[email protected]> wrote:
>> It might be useful to see what breaks if a JDK were built with a newline in >> the vendor name, I assume other things will break. >> >> Overall I think the changes are looking good, the main thing is that the >> error message is clear. > >> It might be useful to see what breaks if a JDK were built with a newline in >> the vendor name, I assume other things will break. > > Writhing the manifest entries for `jrt-fs.jar` break (header validation > fails). Since the vendor populates to that jar file. The CSR is approved, and the one line signature is in the text. And since other things break with newline in the vendor name, I assume that vendor name is also limited, so are we good with current implementation? If it helps, I can add code to ensure compare the whole file. Or are we suggesting to add error message when there is more than one line? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2581726793
