On Tue, 20 Jan 2026 19:17:25 GMT, Volkan Yazici <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add index in testing.html
>
> doc/testing.md line 651:
>
>> 649: tests.
>> 650:
>> 651: For apt-based distributions (Debian, Ubuntu, etc), try this:
>
> *Nit:* I think `{apt,rpm}-based distributions` statements are imprecise. I'd
> rather word it as follows:
>
>> For distributions using the `.deb` packaging format and the `apt` tool (such
>> as Debian, Ubuntu, etc.), try this:
>
> Likewise:
>
>> For distributions using the `.rpm` packaging format and the `dnf` tool (such
>> as Fedora, Red Hat, etc.), try this:
Thanks for the suggestions. The descriptions has been updated.
> doc/testing.md line 660:
>
>> 658:
>> 659: ```
>> 660: sudo yum install -y lksctp-tools
>
> AFAIK, `yum` is succeeded by `dnf`. We may consider using the equivalent
> `dnf` command instead.
Thanks. Fixed.
> doc/testing.md line 662:
>
>> 660: sudo yum install -y lksctp-tools
>> 661: sudo modprobe sctp
>> 662: lsmod | grep sctp
>
> AFAICT, these two steps apply to all type of distributions.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2710797321
PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2710795933
PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2710797861
