On Wed, 21 Jan 2026 14:31:40 GMT, Erik Joelsson <[email protected]> wrote:
>> SendaoYan has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 1. Update apt/dnf description; 2. Add "sudo modprobe sctp" after apt >> install > > doc/testing.html line 629: > >> 627: by default in popular Linux distributions. Without this library, >> 628: the SCTP tests will be skipped. If you want to enable the SCTP tests, >> 629: you should install the SCTP library before run the tests.</p> > > These line lengths look uneven. The html generator tool would not generate it > like that. If I run `make update-build-docs` I get a diff on these lines. > Please make sure the html files you are committing are exactly what the tool > would generate to avoid creating diffs for the next person editing these > files. testing.html has been regenerated by `make update-build-docs`. And only the changes of SCTP been keeped. > doc/testing.md line 649: > >> 647: by default in popular Linux distributions. Without this library, >> 648: the SCTP tests will be skipped. If you want to enable the SCTP tests, >> 649: you should install the SCTP library before run the tests. > > Suggestion: > > you should install the SCTP library before running the tests. > > > Also please fix line breaks so line lengths are uniform and match the rest of > the file. Thanks. The typo has been fixed. And the line length are uniformed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2715101102 PR Review Comment: https://git.openjdk.org/jdk/pull/29320#discussion_r2715098756
