On Fri, 27 Feb 2026 11:05:14 GMT, Matthias Baesken <[email protected]> wrote:
>> We run into compile errors on AIX : >> >> >> /priv/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/src/java.base/share/native/libzip/zlib/zconf.h:470:5: >> error: 'HAVE_UNISTD_H' is not defined, evaluates to 0 [-Werror,-Wundef] >> 470 | #if HAVE_UNISTD_H-0 /* may be set to #if 1 by ./configure */ >> | ^ >> /priv/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/src/java.base/share/native/libzip/zlib/zconf.h:474:5: >> error: 'HAVE_STDARG_H' is not defined, evaluates to 0 [-Werror,-Wundef] >> 474 | #if HAVE_STDARG_H-0 /* may be set to #if 1 by ./configure */ >> | ^ >> 2 errors generated. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Add Linux Thank you for addressing this. I ran this latest change on macos aarch64, Linux `--with-zlib=bundled` and Linux without that option (so system zlib) and all of them continue to build fine. Without the current proposed change for Linux, `--with-zlib=bundled` failed to build for the reasons noted in the JBS issue. So this change looks good to me. ------------- Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29953#pullrequestreview-3866442606
