On Wed, 1 Apr 2026 09:21:13 GMT, Andrew Dinn <[email protected]> wrote:

>> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 1271:
>> 
>>> 1269:   int profile_capture_ratio = ProfileCaptureRatio;
>>> 1270:   int ratio_shift = exact_log2(profile_capture_ratio);
>>> 1271:   auto threshold = (1ull << 32) >> ratio_shift;
>> 
>> Is this just `auto threshold = 1 << (32 - ratio_shift)`?
>
> Why use this here when you use the following simpler approach lower down?
> 
>     uint64_t threshold = (UCONST64(1) << 32) >> ratio_shift;

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3059404347

Reply via email to