On Mon, 30 Mar 2026 13:59:15 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix up any out-of-range offsets > > src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 1235: > >> 1233: assert(masm()->is_C1_MacroAssembler(), "must be"); >> 1234: >> 1235: Label nope; > > Style: `L_nope`. I know of no such style requirement, and it smells of Hungarian Notation, and the label is local to this small block of code. There are about 545 Label declarations in this back end, and only 89 of them use the "L_" convention. We've not used this convention in AArch64 except where we've copied it directly from the x86 reference implementation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3051525814
