On Tue, 14 Apr 2026 06:27:11 GMT, Arno Zeller <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Filter out the function/data sections flags from libjvm gtest build > > make/hotspot/lib/CompileGtest.gmk line 50: > >> 48: ifeq ($(ENABLE_LINKTIME_GC), true) >> 49: ifeq ($(TOOLCHAIN_TYPE), gcc) >> 50: GTEST_LIBJVM_CFLAGS := $(filter-out -ffunction-sections >> -fdata-sections, $(JVM_CFLAGS)) > > Shouldn't GTEST_LIBJVM_CFLAGS be set to JVM_CFLAGS in all other cases? > Otherwise it is undefined. Yes , it needs to be adjusted. Probably that's why I got all those GHA failures. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30516#discussion_r3077824363
