On Thu, 9 Apr 2026 15:41:40 GMT, Erik Joelsson <[email protected]> wrote:
>> Ivan Bereziuk has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'master' into 8357439_bash_autocomplete_for_jcmd >> - copy the autocompletion script to the jdk image >> - move script in bash-completion/ folder and remove extention >> - moved the script from man to conf folder >> - declare functions consistently >> - more clenup >> - copyright header. minor cleanup >> - 8357439: add bash autocompletion for jcmd > > From a pure build point of view, these changes look good. Someone else will > need to weigh in on where in the JDK image we want these kind of files. My > understanding is that the conf dir is for files that are meant to be edited > post installation. At first glance I don't think that's the right location > for this, but I also don't know of a better location. I've changed the `Copy.gmk` so that autocompletion script is not placed to the Windows build. The change is simple but @erikj79 may want to check it once again. I am not sure whether there are thing left to address in this PR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30606#issuecomment-4498540150
