On Thu, 21 May 2026 20:24:44 GMT, Erik Joelsson <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2732 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8385344: [lworld] ProblemList >> tools/javac/platform/CanHandleClassFilesTest.java with --enable-preview >> >> Reviewed-by: fparain >> - 8385301: [lworld] Remove >> serviceability/sa/TestJhsdbJstackMixedWithXComp.java from problem list >> >> Reviewed-by: dsimms >> - 8385331: [lworld] adjust ValueComparisonTest.java again to work around >> JDK-8370769 >> >> Reviewed-by: dsimms >> - 8385311: [lworld] TypePtr::eq() should use accessor method for _offset >> >> Reviewed-by: mchevalier >> - 8385259: [lworld] Clean up LP64 in x86 code >> >> Reviewed-by: dlong, thartmann >> - Merge >> >> Merge jdk-27+23 >> - 8384924: [lworld] misc cleanups >> >> Reviewed-by: thartmann >> - 8385167: [lworld] C1: minor cleanups >> >> Reviewed-by: dlong, thartmann >> - 8384066: [lworld] TestDeadAllocationRemoval.java is ignored by jtreg >> >> Reviewed-by: thartmann >> - ... and 2722 more: https://git.openjdk.org/jdk/compare/86637704...b3b4a2cb > > make/RunTests.gmk line 212: > >> 210: TEST_MODE ASSERT VERBOSE RETAIN TEST_THREAD_FACTORY >> JVMTI_STRESS_AGENT \ >> 211: MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT REPEAT_COUNT MAX_OUTPUT >> REPORT \ >> 212: AOT_JDK MANUAL VALUE_CLASS_PLUGIN >> $(CUSTOM_JTREG_SINGLE_KEYWORDS), \ > > When adding a new option for testing, please add documentation describing > what it is and what it does in doc/testing.[md|html]. It's pretty obvious > this has to do with value classes testing, but what does using the plugin > actually do? Is the option name `VALUE_CLASS_PLUGIN` well suited for the > purpose? By that I mean, is the important part that we are using a plugin, or > that we are testing value classes, or something else? This guy runs by replacing some classes used in some collection tests with a value class version. @bwhuang-us what do you think of this? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3314639969
