On Wed, 3 Jun 2026 08:38:55 GMT, George Adams <[email protected]> wrote:

> Several steps in the Windows CI workflows are duplicated per architecture 
> (x86.x64 / ARM64) where a single step with conditional expressions would 
> suffice.
> 
> Changes:
> 
> - `action.yml`: Merge the two MSYS2 install steps and two path steps into one 
> of each, using expressions for release and location.
> - `build-windows.yml`: Merge the two toolchain check steps into one 
> (conditional on bat file name), and merge the two toolchain install steps 
> into one (component suffix already matches `inputs.architecture`).
> 
> This reduces duplication and makes future architecture additions simpler.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good, assuming the GHA run succeeds and show no issues.

-------------

Marked as reviewed by clanger (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31364#pullrequestreview-4417093424

Reply via email to