On Thu, 14 May 2026 09:08:30 GMT, Andrew Dinn <[email protected]> wrote:
>> Andrew Haley has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 111 commits: >> >> - Merge branch 'master' into JDK-8134940 >> - Review comments >> - Review comments >> - Add FrameMap::last_fpu_reg() >> - Review comments >> - Review comments >> - Review comments >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - More >> - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into >> JDK-8134940 >> - ... and 101 more: https://git.openjdk.org/jdk/compare/3e1d0b8e...4610777b > > src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2618: > >> 2616: case T_INT: { >> 2617: inc *= ProfileCaptureRatio; >> 2618: __ incrementw(counter_address, inc, dest); > > `incrementw(Address, int, Register)` and `increment(Address, int, Register)` > are missing. I assume you intended to add an extra arg to the existing > methods that defaults to `rscratch1`? Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3350651055
