On Wed, 6 May 2026 07:25:48 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Andrew Haley has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 111 commits:
>> 
>>  - Merge branch 'master' into JDK-8134940
>>  - Review comments
>>  - Review comments
>>  - Add FrameMap::last_fpu_reg()
>>  - Review comments
>>  - Review comments
>>  - Review comments
>>  - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into 
>> JDK-8134940
>>  - More
>>  - Merge branch 'JDK-8134940' of https://github.com/theRealAph/jdk into 
>> JDK-8134940
>>  - ... and 101 more: https://git.openjdk.org/jdk/compare/3e1d0b8e...4610777b
>
> src/hotspot/cpu/arm/c1_Runtime1_arm.cpp line 780:
> 
>> 778: #undef FUNCTION_CASE
>> 779:   return "";
>> 780: }
> 
> With `SOFT_FP`, this will produce an extra `}`, breaking the build. Since you 
> have moved the `}` outside the `#ifdef SOFT_FP`, this one should be removed 
> as well.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3357450078

Reply via email to