On Wed, 17 Jun 2026 01:22:10 GMT, 0108maeda <[email protected]> wrote:
>> **Overview:** >> >> This test primarily focuses on the verifying the SOURCE value in the Oracle >> provided OpenJDK build. In the cases except these, in order for the SOURCE >> value to be more flexible, there have been process added where the SOURCE >> value is empty. >> >> **Confirmation of the program after the fix:** >> >> After Fix CheckReleaseFile.java was verified against various SOURCE values, >> including both empty and non-empty cases, to ensure that it processes them >> correctly. The verification was performed using both internally built >> OpenJDK and Oracle's OpenJDK build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > 0108maeda has updated the pull request incrementally with one additional > commit since the last revision: > > Delete WhiteSpace test/jdk/build/releaseFile/CheckReleaseFile.java line 115: > 113: String valueString = valueMatcher.group(1); > 114: > 115: if (valueString == "") { Should not use `==` with objects, even if empty strings are usually constants. I would suggest the below since Matcher::group could return null. Suggestion: if ("".equals(valueString)) { test/jdk/build/releaseFile/CheckReleaseFile.java line 118: > 116: throw new RuntimeException("The test failed, SOURCE value > was empty." + > 117: " JDK Repository used for building might not have .git > directory." + > 118: " Verify that .git was removed from the repository > intentionally."); I'm ok adding a more descriptive error message. I think "Repository" -> "workspace", if it doesn't contain a .git dir, it's probably not a repository, workspace is a more generic term. I would also mention the possibility of a .src-rev file, which the build can produce and consume for this. Suggested text: > The test failed, SOURCE value was empty. The JDK workspace used for building > might not have a .git directory or generated .src-rev file. Verify that > either .git was removed intentionally or generating .src-rev was > intentionally omitted. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31399#discussion_r3425833459 PR Review Comment: https://git.openjdk.org/jdk/pull/31399#discussion_r3425869955
