On Fri, 5 Jun 2026 13:41:23 GMT, Erik Joelsson <[email protected]> wrote:

>> **Overview:**
>> 
>> This test primarily focuses on the verifying the SOURCE value in the Oracle 
>> provided OpenJDK build. In the cases except these, in order for the SOURCE 
>> value to be more flexible, there have been process added where the SOURCE 
>> value is empty.
>> 
>> **Confirmation of the program after the fix:**
>> 
>> After Fix CheckReleaseFile.java was verified against various SOURCE values, 
>> including both empty and non-empty cases, to ensure that it processes them 
>> correctly. The verification was performed using both internally built 
>> OpenJDK  and Oracle's OpenJDK build.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> The purpose of this test for us at Oracle is to verify that SOURCE gets 
> populated even if we build with .git (which is how we produce our official 
> builds), through the .src-rev files we generate before creating source 
> bundles with this make target:
> 
> 
> $ make store-source-revision
> 
> 
> Changing the test this way would make it pass if that rather sensitive part 
> of our build process was to fail. We would need a stronger indication that 
> SOURCE is expected to be empty to allow the test to pass this way.
> 
> Another option for you would be adding an explicit ProblemList to filter out 
> this test in your environment.

Thank you for your code review, @erikj79. I applied your suggestions.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31399#issuecomment-4727713254

Reply via email to