On Fri, 19 Jun 2026 06:14:08 GMT, Julian Waters <[email protected]> wrote:

>> src/hotspot/share/oops/metadata.hpp line 40:
>> 
>>> 38:   // for serviceability tests to work.
>>> 39:   // This can be done by linker settings or modifications to the 
>>> Metadata class.
>>> 40: 
>> 
>> Sorry I haven't been keeping up with this thread. I believe I ask about 
>> PRODUCT builds before. How does all this work with PRODUCT builds since 
>> there is no is_valid() method forcing there to be a Metadata vtable? Can you 
>> also expand the comment a bit to explain why we need both is_valid() and the 
>> linker option?
>
> Hmm, it seems like the Metadata constructor was removed too. Could I ask why? 
> It seems to be needed in NOT_PRODUCT JVMs.

This was a mistake, it is back now !

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30771#discussion_r3440710370

Reply via email to