On Mon, 15 Jun 2026 18:14:01 GMT, Chris Plummer <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> metadata: just add a comment, only rely on the linker setting > > src/hotspot/share/oops/metadata.hpp line 40: > >> 38: // for serviceability tests to work. >> 39: // This can be done by linker settings or modifications to the >> Metadata class. >> 40: > > Sorry I haven't been keeping up with this thread. I believe I ask about > PRODUCT builds before. How does all this work with PRODUCT builds since there > is no is_valid() method forcing there to be a Metadata vtable? Can you also > expand the comment a bit to explain why we need both is_valid() and the > linker option? Alright, I'm fine with it if @plummercj has no further queries, but to answer the question I think only the linker flag is set for now, the comment is just there to explain the situation. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30771#discussion_r3440759281
