On Mon, 29 Jun 2026 11:24:42 GMT, Matthias Baesken <[email protected]> wrote:

> BUILD_LIBJAVA has some warnings disabled, this can be adjusted.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/java.base/unix/native/libjava/TimeZone_md.c line 49:

> 47: 
> 48: #if defined(__linux__) || defined(_ALLBSD_SOURCE)
> 49: static const char *ZONEINFO_DIR = "/usr/share/zoneinfo";

as far as I can tell, the `ZONEINFO_DIR`, `DEFAULT_ZONEINFO_FILE` and 
`popularZones` variables are only used in the `#if defined(__linux__) || 
defined(MACOSX)` section two lines below. Can you move these declarations to 
that section?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31709#discussion_r3514038230

Reply via email to