On Thu, 2 Jul 2026 18:15:39 GMT, Justin Lu <[email protected]> wrote: >> src/java.base/unix/native/libjava/TimeZone_md.c line 49: >> >>> 47: >>> 48: #if defined(__linux__) || defined(_ALLBSD_SOURCE) >>> 49: static const char *ZONEINFO_DIR = "/usr/share/zoneinfo"; >> >> as far as I can tell, the `ZONEINFO_DIR`, `DEFAULT_ZONEINFO_FILE` and >> `popularZones` variables are only used in the `#if defined(__linux__) || >> defined(MACOSX)` section two lines below. Can you move these declarations to >> that section? > > +1 to Daniel's suggestion. I also recommend cleaning up the stale comment of > the corresponding `#endif` on line 473 to `/* defined(__linux__) || > defined(MACOSX) || defined(_AIX) */` while you're at it.
I moved the declarations and adjusted the comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31709#discussion_r3517857834
