On Thu, 16 Jul 2026 09:26:44 GMT, Andrew Haley <[email protected]> wrote:
>> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 1484:
>>
>>> 1482: type_profile_helper(mdo, md, data, recv, Rtmp1);
>>> 1483: } else {
>>> 1484: __ testptr(value, value);
>>
>> Seems to have already did the same thing at L1467.
>
> Well, yes, but `type_profile_helper` just clobbered our flags. That's x86 for
> you.
No it did not? Because you are on the `else` branch here:
_ testptr(value, value); // <--- did it already
if (op->should_profile()) {
...
type_profile_helper(mdo, md, data, recv, Rtmp1);
} else {
__ testptr(value, value); // <--- you are here
...
}
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3594334931
