On Thu, 16 Jul 2026 09:46:37 GMT, Aleksey Shipilev <[email protected]> wrote:

>> Well, yes, but `type_profile_helper` just clobbered our flags. That's x86 
>> for you.
>
> No it did not? Because you are on the `else` branch here:
> 
> 
>     _ testptr(value, value); // <--- did it already
>     if (op->should_profile()) {
>       ...
>       type_profile_helper(mdo, md, data, recv, Rtmp1);
>     } else {
>       __ testptr(value, value); // <--- you are here
>       ...
>     }

Did you mean to pull it *out* of `else` branch then to cover the 
`type_profile_helper` bearing branch?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3594342354

Reply via email to