On Mon, 24 Aug 2026 08:14:47 GMT, Amit Kumar <[email protected]> wrote:
>> Harshit Dhiman has updated the pull request incrementally with one >> additional commit since the last revision: >> >> don;t set cc > > src/hotspot/cpu/s390/gc/z/z_s390.ad line 54: > >> 52: __ z_lgr(Z_R0_scratch, ref); >> 53: __ relocate(barrier_Relocation::spec(), >> ZBarrierRelocationFormatMarkBadBeforeTest); >> 54: __ z_nill(Z_R0_scratch, barrier_Relocation::unpatched); > > can't you use `z_tmll` here and get rid of Z_R0 altogether ? you should update the below condition code check from Assembler::bcondNotZero to Assembler::bcondNotAllZero, if you are going with z_tmll. same for line 84. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3841766587
