On Mon, 24 Aug 2026 12:43:44 GMT, Yunbo Zhang <[email protected]> wrote:

> After [8288396: Always create reproducible 
> builds](https://github.com/openjdk/jdk/commit/b4ab5fe1daf22a543e1bd973bcd34322360054b4),
>  `abstract_vm_version.cpp` uses `HOTSPOT_BUILD_TIME` instead of `__DATE__` 
> and `__TIME__`.
> 
> However, `abstract_vm_version.o` still depends on the other `libjvm` target 
> dependencies. This can cause it to be rebuilt when an unrelated HotSpot 
> source file is changed. This dependency is no longer needed.
> 
> Testing:
> - Touched `src/hotspot/share/runtime/arguments.cpp` and rebuilt with 
> `LOG=debug`.
> - `arguments.cpp` was recompiled, but no compile command for 
> `abstract_vm_version.cpp` was generated.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Good catch! Thank you for finding and removing this leftover.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32505#pullrequestreview-5008641939

Reply via email to