On Mon, 24 Aug 2026 11:42:23 GMT, Harshit Dhiman <[email protected]> wrote:
>> Port the Z garbage collector to s390. >> >> The tier1 test case are passing using `-XX:+UseZGC` flag >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Harshit Dhiman has updated the pull request incrementally with one additional > commit since the last revision: > > add some more comments src/hotspot/cpu/s390/gc/z/z_s390.ad line 159: > 157: match(Set res (CompareAndExchangeP mem (Binary oldval newval))); > 158: predicate(UseZGC && n->as_LoadStore()->barrier_data() != 0); > 159: effect(TEMP_DEF res, USE mem, TEMP newval_temp, KILL cr); Suggestion: effect(TEMP_DEF res, USE mem, TEMP newval_temp, KILL cr); src/hotspot/cpu/s390/gc/z/z_s390.ad line 219: > 217: __ z_csg($temp2$$Register, $temp1$$Register, mem_addr); > 218: __ branch_optimized(Assembler::bcondNotEqual, retry); > 219: __ z_srlg($newval$$Register, $temp2$$Register, ZPointerLoadShift); just add one comment here also, that we are un-coloring the pointer here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3849393953 PR Review Comment: https://git.openjdk.org/jdk/pull/31984#discussion_r3849492656
