On Sun, 20 Sep 2026 04:40:39 GMT, Ashutosh Mehra <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update AOT code tests timeout value. Move two tests to tier2
>
> src/hotspot/share/ci/ciField.cpp line 373:
>
>> 371: return ciConstant();
>> 372: }
>> 373: if (CURRENT_ENV->is_aot_compile()) { // Restrict only when we
>> generate AOT code
>
> This check can be moved to the top of the method to avoid executing other
> code when this condition is true.
I can move it above FoldStableValues check. I see that _constant_value is
directly accessed in ciField::print(). If I move AOT check to the beginning,
ciField::print() will produce different output.
Main reason AOT check is placed at the end of these methods is it is true only
in AOT assembly phase during AOT compilation. I don't want to slow down normal
execution.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4058249293
