On Sun, 20 Sep 2026 04:39:50 GMT, Ashutosh Mehra <[email protected]> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update AOT code tests timeout value. Move two tests to tier2
>
> src/hotspot/share/cds/aotCacheAccess.cpp line 98:
>
>> 96:
>> 97: Metadata* meta = reinterpret_cast<Metadata*>(base + offset);
>> 98: assert(Metaspace::in_aot_cache(meta), "must be");
>
> Isn't `Metaspace::in_aot_cache(meta)` sufficient to detect spurious/corrupted
> narrowPtr?
There could be arithmetic overflow.
> src/hotspot/share/ci/ciInstanceKlass.cpp line 65:
>
>> 63: if (!ik->is_loaded()) {
>> 64: ResourceMark rm;
>> 65: ik->print_on(tty);
>
> Is this required? Next assert statement already prints the name.
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4058287319
PR Review Comment: https://git.openjdk.org/jdk/pull/30778#discussion_r4058289999
