#900: console: exceptions everywhere
-------------------+--------------------------------------------------------
Reporter: axel | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.0 | Keywords: console pink exception
-------------------+--------------------------------------------------------
Hi,
for me, all console builds are pink. Debugging showed that results in
getResultsClass() was in fact a list. I changed console.py to
--- status/web/console.py.org 2010-05-24 17:31:03.000000000 +0200
+++ status/web/console.py 2010-06-18 12:15:11.328747895 +0200
@@ -19,9 +19,15 @@
if results is None:
return "notstarted"
+ if type(results) in (tuple, list):
+ results = max(results)
+
if results == builder.SUCCESS:
return "success"
and now it works.
While at it, I added "warnings" as a legal result:
--- status/web/console.py.org 2010-05-24 17:31:03.000000000 +0200
+++ status/web/console.py 2010-06-18 12:15:11.328747895 +0200
@@ -19,9 +19,15 @@
if results is None:
return "notstarted"
+ if type(results) in (tuple, list):
+ results = max(results)
+
if results == builder.SUCCESS:
return "success"
+ if results == builder.WARNINGS:
+ return "warnings"
+
if results == builder.FAILURE:
if not prevResults:
# This is the bottom box. We don't know if the previous one
failed
Cheers, Axel.
--
Ticket URL: <http://buildbot.net/trac/ticket/900>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
