#1049: Maybe bogus assertion
--------------------+-------------------------------------------------------
Reporter: qzhwang | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.1 | Keywords:
--------------------+-------------------------------------------------------
The assertion on line 103 of buildbot/sourcestamp.py for 0.8.1p1 seems to
be redundant. Here's the code:
for req in others:
assert self.canBeMergedWith(req) # should have been checked
already
changes.extend(req.changes)
It normally works fine. But if I have a customized mergeRequests to merge
some requests o.w. won't be mregeable, this assertion will fail. I have to
comment it out for our mergeRequests to work. I'm wondering if this
assertion really considers the situation where the user supplied their own
mergeRequests function.
--
Ticket URL: <http://buildbot.net/trac/ticket/1049>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
The Next 800 Companies to Lead America's Growth: New Video Whitepaper
David G. Thomson, author of the best-selling book "Blueprint to a
Billion" shares his insights and actions to help propel your
business during the next growth cycle. Listen Now!
http://p.sf.net/sfu/SAP-dev2dev
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
