On 4/10/07, Robin Farine <[EMAIL PROTECTED]> wrote: > Hi, > > On Tue April 10 2007 01:48, Larry Brigman wrote: > > When Wall is on busybox config also turns on Werror. Because of > > this touch causes the make to fail because of invalid NULL > > parameter. > > > > This patch fixes the problem. > > Hmm, I think it introduces a bug since utime's semantics depends on > whether the second argument is NULL or not. If it is not NULL but > points to an uninitialized instance of struct utimbuf, utime will > probably have some strange effects :-). > > It looks like the real problem lies in the compiler, NULL is > perfectly valid here. What warning does the compiler spit out? >
It is a warning not an error but when Wall is set busybox config sets Werror which turns this warning into a build error. Output of make V=1 mips64_octeon_be-gcc -Wp,-MD,coreutils/.touch.o.d -std=gnu99 -Iinclude -Ilibbb -I/home/lbrigman/sandbox/cavium/vendor/pkg/busybox-1.4.2/libbb -include include/autoconf.h -D_GNU_SOURCE -DNDEBUG -D"BB_VER=KBUILD_STR(1.4.2)" -DBB_BT=AUTOCONF_TIMESTAMP -Wall -Wstrict-prototypes -Wshadow -Werror -Wundef -funsigned-char -fno-builtin-strlen -finline-limit=0 -static-libgcc -Os -falign-functions=1 -falign-jumps=1 -falign-loops=1 -fomit-frame-pointer -ffunction-sections -fdata-sections -Wdeclaration-after-statement -Wall -I/home/lbrigman/sandbox/cavium/vendor/cai/include -I/home/lbrigman/sandbox/cavium/vendor/include -I/home/lbrigman/sandbox/cavium/buildtools/montavista/pro/devkit/mips64/octeon_be/target/usr/include -mabi=64 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(touch)" -D"KBUILD_MODNAME=KBUILD_STR(touch)" -c -o coreutils/touch.o coreutils/touch.c coreutils/touch.c: In function `touch_main': coreutils/touch.c:44: warning: null argument where non-null required (arg 2) _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
