On Tuesday 24 June 2008 18:00, Denys Vlasenko wrote:
> On Monday 23 June 2008 19:02, [EMAIL PROTECTED] wrote:
> > Hello, Denys!
> >
> > Made a patch:
> > 1. lsmod, modprobe, rmmod, depmod retain compatible interface: 1717 octets
> > for all.
>
> Wow.
>
> > 2. insmod: do we really need to "publish" it as applet?
>
> Ja ja. We love our users, we don't want to upset them by having
> insmod disappear (or change interface).
>
> > 3. modules.dep move to /tmp/modules.dep.bb: that way we ensure we can
> > [re]create it.
>
> I propose that an attempt should be made to copy it to
> /lib/modules/$KERNELVERSION. If that fails, maybe issue a diagnostic
> ("cannot copy, will regenerate $FILE on every run [which is slow]").
> Come to think about it, instead of "/tmp/modules.dep.bb" you may
> call fd = mkstemp(DEFAULT_DEPMOD_FILE ".bb.XXXXXX") - makes you
> safe versus modprobe races...
>
> > Please, do try and test.
Another thing I want to ask: please document modules.dep.bb format
in a big comment at the top of modprobe-ng.c. Be verbose there.
--
vda
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
