On Thursday 11 September 2008 19:26:48 Vladimir Dronnikov wrote:
> I'd make this both FEATURED and depending on CONFIG_DESKTOP, Walter.
> 
> --
> Vladimir
Hi Walter,
at a first glance:

1) there is  indentation and whitespace breakage;

2) the build breaks if CONFIG_USE_BB_PWD_GRP is set:
        coreutils/lib.a(id.o): In function `id_main':
        id.c:(.text.id_main+0x156): undefined reference to 
`bb_internal_getgrouplist'
        id.c:(.text.id_main+0x181): undefined reference to 
`bb_internal_getgrouplist'
        /usr/bin/ld: busybox_unstripped: hidden symbol 
`bb_internal_getgrouplist' isn't
        defined
        /usr/bin/ld: final link failed: Nonrepresentable section on output      
        collect2: ld returned 1 exit status
        make: *** [busybox_unstripped] Error 1

3) the output seems to differ from that of coreutils id in that the groups are 
shown 
    from higher to lower numbers:
id -G
0 46
./busybox id -G
46 0

4) the -G switch must be mutually exclusive with -u and -g:

id -Gu
id: cannot print "only" of more than one choice
id -Gg
id: cannot print "only" of more than one choice

./busybox id -Gu
0
debian:~/Desktop/busybox# ./busybox id -Gg
0

Ciao,
Tito

_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to