Tito schrieb: > On Thursday 11 September 2008 21:43:24 Tito wrote: >> On Thursday 11 September 2008 19:26:48 Vladimir Dronnikov wrote: >>> I'd make this both FEATURED and depending on CONFIG_DESKTOP, Walter. >>> > > Hi, > just for fun here is a different approach for adding the -G switch to id. > I tested it a bit and it seems to work and to behave like the GNU id. > Maybe this code could be added to CONFIG_DESKTOP. > Size increase is: > function old new delta > id_main 293 494 +201 > .rodata 118792 118823 +31 > printf_full 49 44 -5 > ------------------------------------------------------------------------------ > (add/remove: 0/0 grow/shrink: 2/1 up/down: 232/-5) Total: 227 bytes > > > Hints, critics and improvements are as always welcome. >
I did not compile it but it looks ok at first glance. We should not go for CONFIG_DESKTOP since we trend to emulate coreutils default behavier as "normal". id clearly did differ here, not nice for size but .... btw: do we have a list what we want to say with: CONFIG_DESKTOP or FEATURED ? Just i few lines that explain the idea behind it ? (beside the help stuff in the makefile ?) re, wh _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
