>
> Looks like a bug:
>
> +                       char *s = ptr + strlen(ptr) + 1;
> +                       s = ptr + strlen(ptr) + 1;


Nope. The intention is to skip two strings: module name itself and the path
to the module, as they definitely do not match the alias.

Please use opts = getopt32(...), it's usually smaller to use local
> variable (gcc can cache it in register) than global one:


But I need modified option_mask32 in process_module()... To make G.opts is
even larger...

+#if ENABLE_FEATURE_MODUTILS_FAST_OPTIONS_ON_CMDLINE
> +       if (!(option_mask32 & OPT_r) && !(option_mask32 & OPT_a)) {
>
> !(option_mask32 & (OPT_r+OPT_a))


Got the idea. Thanks!
--
Vladimir
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to