On Tue, Nov 04, 2008 at 03:03:39PM +0000, Roy Marples wrote: >On Tuesday 04 November 2008 14:58:30 Roy Marples wrote: >> So, in an attempt yet again to get OpenRC to boot cleanly using busybox >> here's a patch that enables -C device for kbd_mode and setfont. The patch >> is done so extending similar support for other console tools is fairly >> trivial. > >I forgot to attach the patch! How embarrasing :) >Anyway, attached > >uberlaptop busybox-1.12.1 # ./scripts/bloat-o-meter ../*orig/busybox busybox >function old new delta >get_console_fd_or_die 141 193 +52 >.rodata 163385 163419 +34 >packed_usage 24130 24158 +28 >kbd_mode_main 223 241 +18 >setfont_main 194 208 +14 >loadfont_main 103 117 +14 >setkeycodes_main 186 191 +5 >loadkmap_main 246 251 +5 >dumpkmap_main 280 285 +5 >deallocvt_main 102 107 +5 >chvt_main 61 66 +5 >static.KD_xxx 5 7 +2 >------------------------------------------------------------------------------ >(add/remove: 0/0 grow/shrink: 12/0 up/down: 187/0) Total: 187 bytes
Given these stats you should add a get_console_fd_from_name_or_die(const char *dev) instead of adding penalties for the NULL arg everywhere. _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
