On Tue, Nov 04, 2008 at 04:52:42PM +0000, Roy Marples wrote:
>On Tuesday 04 November 2008 15:46:56 Bernhard Reutner-Fischer wrote:
>> Given these stats you should add a
>> get_console_fd_from_name_or_die(const char *dev) instead of adding
>> penalties for the NULL arg everywhere.
>
>That saves a futher 30 bytes.

>+int FAST_FUNC get_console_fd_from_name_or_die(const char *device)
>+{
>+      int fd;
>+
>+      fd = open_a_console(device);
>+      if (fd != -1)
>+              return fd;

you don't sanity-check the KDGKBTYPE..
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to