On Saturday 24 January 2009 08:06:02 Cristian Ionescu-Idbohrn wrote: > Emacs does not grok quotes in makefile subs very well, and screws up > colorized code :( > Similar to the CONFIG_EXTRA_CFLAGS, please accept this patch: > > --- busybox/Makefile (revision 23984) > +++ busybox/Makefile (working copy) > @@ -168,6 +168,7 @@ > CROSS_COMPILE := $(shell grep ^CONFIG_CROSS_COMPILER_PREFIX .config > 2>/dev/null) CROSS_COMPILE := $(subst > CONFIG_CROSS_COMPILER_PREFIX=,,$(CROSS_COMPILE)) CROSS_COMPILE := $(subst > ",,$(CROSS_COMPILE)) > +#") > endif
Do we really want to pollute the code with unexplained workarounds for purely cosmetic bugs in a text editor many of us don't use? Did you at least poke the emacs guys and ask them to fix their obvious bug? (Parsing complexity aside, I don't believe quotes span multiple lines in make, so the highlighting should have stopped at the end of line anyway.) Rob _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
