On Tuesday 27 January 2009 12:44:46 Cristian Ionescu-Idbohrn wrote: > On Mon, 26 Jan 2009, Rob Landley wrote: > > On Saturday 24 January 2009 08:06:02 Cristian Ionescu-Idbohrn wrote: > > > Emacs does not grok quotes in makefile subs very well, and screws up > > > colorized code :( > > > Similar to the CONFIG_EXTRA_CFLAGS, please accept this patch: > > > > > > --- busybox/Makefile (revision 23984) > > > +++ busybox/Makefile (working copy) > > > @@ -168,6 +168,7 @@ > > > CROSS_COMPILE := $(shell grep ^CONFIG_CROSS_COMPILER_PREFIX .config > > > 2>/dev/null) CROSS_COMPILE := $(subst > > > CONFIG_CROSS_COMPILER_PREFIX=,,$(CROSS_COMPILE)) CROSS_COMPILE := > > > $(subst ",,$(CROSS_COMPILE)) > > > +#") > > > endif > > > > Do we really want to pollute the code with unexplained workarounds for > > purely cosmetic bugs in a text editor many of us don't use? > > Many of _who_? > Did you have a bad day?
Several. Busybox includes a vi implementation. It does not include an emacs implementation. There's also nano and gnotepad and kate and so on. Hence a workaround for a bug in emacs seemed worth questioning. > Shall we start another flame war and/or text editor investigation? Asking whether something is a good idea constitutes a flamewar? > > (Parsing complexity aside, I don't believe quotes span multiple lines in > > make, so the highlighting should have stopped at the end of line > > anyway.) > > I actually found one :) Makefile, lines 1194-1201: > > define cmd_tags > rm -f $@; \ > CTAGSF=`ctags --version | grep -i exuberant >/dev/null && \ > echo "-I __initdata,__exitdata,__acquires,__releases \ > -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ > --extra=+f --c-kinds=+px"`; \ > $(all-sources) | xargs ctags $$CTAGSF -a > endef That would be a trailing backslash gluing together multiple lines, which is separate from a quoted string spanning multiple lines on its own. > Let's just forget about all that. Your definition of "forget" is "merge the patch, and any future ones like this that come along to work around the same bug". *shrug* That's what Denys did, and it's his call... > Cheers, Seinfeld, Rob _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
