2009/7/21 Denys Vlasenko <[email protected]>: > On Tuesday 21 July 2009 19:35, Alexander Shishkin wrote: >> 2009/6/18 Denys Vlasenko <[email protected]>: >> > On Friday 12 June 2009 18:27, [email protected] wrote: >> >> From: Pekka Pessi <[email protected]> >> >> >> >> Issue fsync() system call on a file to ensure its buffers are synchronized >> >> with the backing storage. >> >> >> >> Signed-off-by: Alexander Shishkin <[email protected]> >> > >> > Committed to git after a slight code shrink. Thanks! >> >> Oh, good. One thing though. I'm totally fine with fixing patches or >> commit messages before committing (i.e. not using git-am, or using >> git-am and amending the commit afterwards), but it would be better if >> 'Author' field retained author's name (it was incorrect in the last >> version that I sent as well, indeed) thus giving him proper credit for >> the contribution. > > You mean this? > > commit 14f6f0ad4a9d07f927b96b08c20d7ea546318517 > Author: Denys Vlasenko <[email protected]> > Date: Thu Jun 18 08:20:02 2009 +0200 > > fsync: new applet by Pekka Pessi (Pekka.Pessi AT nokia.com) > > function old new delta > fsync_main - 128 +128 > fdatasync - 39 +39 > packed_usage 26596 26622 +26 > applet_names 2098 2104 +6 > applet_main 1240 1244 +4 > applet_nameofs 620 622 +2 > applet_install_loc 155 156 +1 > > ------------------------------------------------------------------------------ > (add/remove: 2/0 grow/shrink: 5/0 up/down: 206/0) Total: 206 > bytes > > Signed-off-by: Alexander Shishkin <[email protected]> > Signed-off-by: Denys Vlasenko <[email protected]> Yep.
> It looks like this because I use "git commit -a -s" + "git push". > If I do that, "Author:" is added automatically. It is. However, you can have git apply patches directly from your mail. Like git-am (former git-applymbox, afair) does. Then you can use 'git commit --amend' or 'git reset --soft && edit && git commit -C ORIG_HEAD'. > I don't know much about git yet. > > Do you know how to specify author for git to record? --author option to git-commit should do this as well. > # git help am > man: no manual entry for 'git-am' Hm. Either your git is too old or mine. As I mentioned, it was previously called applymbox, I'm not sure if they had to rename it once again and even if they do such things, they usually leave the deprecated version in place for a while for compatibility. Anyway, what does your git --version say? [Man, life is so much better when you use a binary distro] Regards, -- Alex _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
