On Sunday 21 February 2010 11:35, Harald Becker wrote: > There seems to be a bug in the install applet. Possibly long standing. > > If you install a file with -s (strip symbols) and -p (preserve date/time > etc.), it does first copy the file (preserving the date and time > correctly) and afterwards strip is called, just as the last step. But > stripping always changes the date and time of the file to the current > date and time, and not only the time gets tampered, strip clears suid or > sgid bits which may have been set with -m. > > The date and time can be preserved by using "strip -s", but some > reordering of the existing code is required to preserve the suid/sgid bits. > > Patch to fix the bug in install appended, but I don't know if strip or > my code reordering may produce any conflict with setting the security > context (I don't use SELinux). So could anybody with SELinux be so > kindly to check this, please?
This your patch again has broken indentation. I moved "strip" call up and added "-p". Please let me know whether current git is still not good enough for you. -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
