Bernhard Reutner-Fischer wrote:
On Mon, Mar 08, 2010 at 06:06:17PM +0000, Nuno Lucas wrote:
Thanks. I will look into submitting a patch then.

please do. You probably want something like (untested):
index 3bf16ab..ed9a8da 100644
--- a/miscutils/fbsplash.c
+++ b/miscutils/fbsplash.c
@@ -264,8 +264,8 @@ static void fb_drawimage(void)
if (ENABLE_FEATURE_CLEAN_UP)
                free(head);
-       if (width != G.scr_var.xres || height != G.scr_var.yres)
-               bb_error_msg_and_die("PPM %dx%d does not match screen %dx%d",
+       if (width > G.scr_var.xres || height > G.scr_var.yres)
+               bb_error_msg_and_die("PPM %dx%d does fit on screen %dx%d",
                                                         width, height, 
G.scr_var.xres, G.scr_var.yres);
        line_size = width*3;
        if (width > G.scr_var.xres)

Thanks. That may work for my current needs (haven't tested it yet), but I was thinking on fixing the rendering routines to allow any image size. That seems to be the right fix. On first glance it seems to miss a "not", though ;-)

I haven't started working on this yet as I have other things to do right now, but will look into it eventually.


Regards,
~Nuno Lucas
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to